for ( ctr2 = 0; ctr2 < 25; ctr2++ )
{
printf( “%c”, star);
}
}
}- This program actually works properly, but it could be better. First of all, there is no
need to initialize the variable xto 1 , because it’s initialized to 0 in the forstate-
ment. Also, declaring the variable tallyto be static is pointless because, within the
main()function, static keywords have no effect. - What is the value of star? What is the value of dash? These two variables are
never initialized. Because they are both local variables, each could contain any
value. Note that, although this program compiles with no errors or warnings, there
is still a problem.
There is a second issue that should be brought up about this program. The variable
ctris declared as global, but it’s only used in print_function(). This isn’t a
good assignment. The program would be better if ctrwere a local variable in
print_function(). - This program prints the following pattern forever. See exercise 10.
X==X==X==X==X==X==X==X==X==X==X==X==X==X==X==X==X==... - This program poses a problem because of the global scope of ctr. Both main()
andprint_letter2()usectrin loops at the same time. Because print_let-
ter2()changes the value, the forloop in main()never completes. This could be
fixed in a number of ways. One way is to use two different counter variables. A
second way is to change the scope of the counter variable ctr. It could be declared
in both main()andprint_letter2()as a local variable.
An additional comment on letter1andletter2. Because each of these is used in
only one function, they should be declared as local. Here is the corrected listing:
#include <stdio.h>
void print_letter2(void); / function prototype /
int main( void )
{
char letter1 = ‘X’;
int ctr;
for( ctr = 0; ctr < 10; ctr++ )
{
printf( “%c”, letter1 );
print_letter2();
}862 Appendix F49 448201x-APP F 8/13/02 11:22 AM Page 862